Reply

If it helps the ending is so lovely and 🧡 that I didn't mind it ending as much

by Jamie Tanna's profile image Jamie Tanna .

 Reply

I dislike working at a big company like this too 😥

by Jamie Tanna's profile image Jamie Tanna . #open-source.

 Reply

We've found it to work quite well on my team, as it allows folks to see things they're not necessarily involved in, and actively seeks out their thoughts, as well as not leaving it up to the PR raiser to decide who

(Although we're currently using the "round Robin" approach)

It also doesn't mean others can't review

by Jamie Tanna's profile image Jamie Tanna . #code-review #github.

 Reply

Hmm I'll have to try it but I thought rebase-merge was the same as a --no-ff merge

by Jamie Tanna's profile image Jamie Tanna . #git #github.

 Reply

You can also do this with a "rebase merge" on GitHub, and yep would recommend it if you don't want merge commits. I'd generally say keep them, but amend the titles to be ie PR title

by Jamie Tanna's profile image Jamie Tanna . #github.

 Reply

Glad you found it, this one has bitten me before, too 😂

by Jamie Tanna's profile image Jamie Tanna . #junit.